McDonald's fries are only good when they're freshly made. If they've been sitting under the heating lamp, fuhgheddaboutit.
I've never been to White Castle, but I've had their frozen sliders, which aren't bad, considering they're frozen.
The best french fries I've EVER had were from Thrasher's, on the boardwalk in Ocean City, Maryland. Big, and greasy. Sprinkle some salt and a little apple cider vinegar on those bad boys, and you're in deep fried potato heaven.