We've discussed this elsewhere, but I can't find any of the links. Anyway, you're right, it was an atypically stupid move on Vito's part, and certainly the biggest blunder of his career. Luca's loyalty went beyond whatever vows he took. It was tribal; practically archaic. Sollozzo and the other Dons would never have believed him to be a traitor.